refactor: technical debt cleanup for v2.1.6

- Fix version mismatch (2.0.0 → 2.1.5 in main plugin file)
- Fix modal FOUC (CSS defaults to display:none, JS adds .active class)
- Replace direct error_log() with HVAC_Logger for conditional debug logging
- All logging now respects WP_DEBUG flag for production cleanliness

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
ben 2025-11-03 20:41:08 -04:00
parent 2a06bb1f15
commit f92ea45286
4 changed files with 21 additions and 27 deletions

View file

@ -172,11 +172,16 @@
height: 100%; height: 100%;
background: rgba(0, 0, 0, 0.5); background: rgba(0, 0, 0, 0.5);
z-index: 100000; /* Below WordPress media modal (160000) to allow media library to stack on top */ z-index: 100000; /* Below WordPress media modal (160000) to allow media library to stack on top */
display: flex; display: none; /* Hidden by default to prevent FOUC */
justify-content: center; justify-content: center;
align-items: center; align-items: center;
} }
/* Modal active state - shown by JavaScript */
.hvac-modal.active {
display: flex;
}
.modal-content { .modal-content {
background: white; background: white;
width: 90%; width: 90%;

View file

@ -3,7 +3,7 @@
* Plugin Name: HVAC Community Events * Plugin Name: HVAC Community Events
* Plugin URI: https://upskillhvac.com * Plugin URI: https://upskillhvac.com
* Description: Custom plugin for HVAC trainer event management system * Description: Custom plugin for HVAC trainer event management system
* Version: 2.0.0 * Version: 2.1.6
* Author: Upskill HVAC * Author: Upskill HVAC
* Author URI: https://upskillhvac.com * Author URI: https://upskillhvac.com
* License: GPL-2.0+ * License: GPL-2.0+

View file

@ -40,54 +40,43 @@ class HVAC_Announcements_Admin {
* Constructor * Constructor
*/ */
private function __construct() { private function __construct() {
error_log('HVAC_Announcements_Admin: Constructor called - initializing hooks'); HVAC_Logger::log('Constructor called - initializing hooks', 'Announcements Admin');
$this->init_hooks(); $this->init_hooks();
error_log('HVAC_Announcements_Admin: Hooks initialized successfully'); HVAC_Logger::log('Hooks initialized successfully', 'Announcements Admin');
} }
/** /**
* Initialize hooks * Initialize hooks
*/ */
private function init_hooks() { private function init_hooks() {
error_log('HVAC_Announcements_Admin: Registering wp_enqueue_scripts hook with priority 20'); HVAC_Logger::log('Registering wp_enqueue_scripts hook with priority 20', 'Announcements Admin');
// Use priority 20 to ensure post object is available // Use priority 20 to ensure post object is available
add_action('wp_enqueue_scripts', array($this, 'enqueue_admin_assets'), 20); add_action('wp_enqueue_scripts', array($this, 'enqueue_admin_assets'), 20);
error_log('HVAC_Announcements_Admin: Hook registered successfully'); HVAC_Logger::log('Hook registered successfully', 'Announcements Admin');
// Also try init hook to verify hooks are working at all
add_action('init', array($this, 'test_hook'));
}
/**
* Test hook to verify hooks are working
*/
public function test_hook() {
error_log('HVAC_Announcements_Admin: TEST HOOK FIRED - hooks are working!');
} }
/** /**
* Enqueue admin assets on master trainer pages * Enqueue admin assets on master trainer pages
*/ */
public function enqueue_admin_assets() { public function enqueue_admin_assets() {
// Debug logging HVAC_Logger::log('enqueue_admin_assets called', 'Announcements Admin');
error_log('HVAC Announcements Admin: enqueue_admin_assets called'); HVAC_Logger::log('is_master_trainer = ' . (HVAC_Announcements_Permissions::is_master_trainer() ? 'YES' : 'NO'), 'Announcements Admin');
error_log('HVAC Announcements Admin: is_master_trainer = ' . (HVAC_Announcements_Permissions::is_master_trainer() ? 'YES' : 'NO')); HVAC_Logger::log('is_page_template check = ' . (is_page_template('page-master-announcements.php') ? 'YES' : 'NO'), 'Announcements Admin');
error_log('HVAC Announcements Admin: is_page_template check = ' . (is_page_template('page-master-announcements.php') ? 'YES' : 'NO'));
$queried = get_queried_object(); $queried = get_queried_object();
if ($queried) { if ($queried) {
error_log('HVAC Announcements Admin: queried_object type = ' . get_class($queried)); HVAC_Logger::log('queried_object type = ' . get_class($queried), 'Announcements Admin');
if (is_a($queried, 'WP_Post')) { if (is_a($queried, 'WP_Post')) {
error_log('HVAC Announcements Admin: post_name = ' . $queried->post_name); HVAC_Logger::log('post_name = ' . $queried->post_name, 'Announcements Admin');
error_log('HVAC Announcements Admin: post_type = ' . $queried->post_type); HVAC_Logger::log('post_type = ' . $queried->post_type, 'Announcements Admin');
$template = get_post_meta($queried->ID, '_wp_page_template', true); $template = get_post_meta($queried->ID, '_wp_page_template', true);
error_log('HVAC Announcements Admin: page_template meta = ' . $template); HVAC_Logger::log('page_template meta = ' . $template, 'Announcements Admin');
} }
} }
// Only enqueue on master trainer announcement pages // Only enqueue on master trainer announcement pages
if ($this->is_master_trainer_announcement_page()) { if ($this->is_master_trainer_announcement_page()) {
error_log('HVAC Announcements Admin: ENQUEUING SCRIPTS'); HVAC_Logger::log('ENQUEUING SCRIPTS', 'Announcements Admin');
// Enqueue editor - dependencies handled automatically // Enqueue editor - dependencies handled automatically
wp_enqueue_editor(); wp_enqueue_editor();

View file

@ -115,7 +115,7 @@ final class HVAC_Plugin {
define('HVAC_PLUGIN_VERSION', '2.0.0'); define('HVAC_PLUGIN_VERSION', '2.0.0');
} }
if (!defined('HVAC_VERSION')) { if (!defined('HVAC_VERSION')) {
define('HVAC_VERSION', '2.1.5'); define('HVAC_VERSION', '2.1.6');
} }
if (!defined('HVAC_PLUGIN_FILE')) { if (!defined('HVAC_PLUGIN_FILE')) {
define('HVAC_PLUGIN_FILE', dirname(__DIR__) . '/hvac-community-events.php'); define('HVAC_PLUGIN_FILE', dirname(__DIR__) . '/hvac-community-events.php');