From f92ea45286521aebdec565dc96c10e2f87534f11 Mon Sep 17 00:00:00 2001 From: ben Date: Mon, 3 Nov 2025 20:41:08 -0400 Subject: [PATCH] refactor: technical debt cleanup for v2.1.6 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fix version mismatch (2.0.0 → 2.1.5 in main plugin file) - Fix modal FOUC (CSS defaults to display:none, JS adds .active class) - Replace direct error_log() with HVAC_Logger for conditional debug logging - All logging now respects WP_DEBUG flag for production cleanliness 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- assets/css/hvac-announcements-admin.css | 7 +++- hvac-community-events.php | 2 +- includes/class-hvac-announcements-admin.php | 37 ++++++++------------- includes/class-hvac-plugin.php | 2 +- 4 files changed, 21 insertions(+), 27 deletions(-) diff --git a/assets/css/hvac-announcements-admin.css b/assets/css/hvac-announcements-admin.css index 2af15796..58fc59e8 100644 --- a/assets/css/hvac-announcements-admin.css +++ b/assets/css/hvac-announcements-admin.css @@ -172,11 +172,16 @@ height: 100%; background: rgba(0, 0, 0, 0.5); z-index: 100000; /* Below WordPress media modal (160000) to allow media library to stack on top */ - display: flex; + display: none; /* Hidden by default to prevent FOUC */ justify-content: center; align-items: center; } +/* Modal active state - shown by JavaScript */ +.hvac-modal.active { + display: flex; +} + .modal-content { background: white; width: 90%; diff --git a/hvac-community-events.php b/hvac-community-events.php index 116fa3ad..bf867595 100644 --- a/hvac-community-events.php +++ b/hvac-community-events.php @@ -3,7 +3,7 @@ * Plugin Name: HVAC Community Events * Plugin URI: https://upskillhvac.com * Description: Custom plugin for HVAC trainer event management system - * Version: 2.0.0 + * Version: 2.1.6 * Author: Upskill HVAC * Author URI: https://upskillhvac.com * License: GPL-2.0+ diff --git a/includes/class-hvac-announcements-admin.php b/includes/class-hvac-announcements-admin.php index 626c84e7..40e14829 100644 --- a/includes/class-hvac-announcements-admin.php +++ b/includes/class-hvac-announcements-admin.php @@ -40,54 +40,43 @@ class HVAC_Announcements_Admin { * Constructor */ private function __construct() { - error_log('HVAC_Announcements_Admin: Constructor called - initializing hooks'); + HVAC_Logger::log('Constructor called - initializing hooks', 'Announcements Admin'); $this->init_hooks(); - error_log('HVAC_Announcements_Admin: Hooks initialized successfully'); + HVAC_Logger::log('Hooks initialized successfully', 'Announcements Admin'); } - + /** * Initialize hooks */ private function init_hooks() { - error_log('HVAC_Announcements_Admin: Registering wp_enqueue_scripts hook with priority 20'); + HVAC_Logger::log('Registering wp_enqueue_scripts hook with priority 20', 'Announcements Admin'); // Use priority 20 to ensure post object is available add_action('wp_enqueue_scripts', array($this, 'enqueue_admin_assets'), 20); - error_log('HVAC_Announcements_Admin: Hook registered successfully'); - - // Also try init hook to verify hooks are working at all - add_action('init', array($this, 'test_hook')); - } - - /** - * Test hook to verify hooks are working - */ - public function test_hook() { - error_log('HVAC_Announcements_Admin: TEST HOOK FIRED - hooks are working!'); + HVAC_Logger::log('Hook registered successfully', 'Announcements Admin'); } /** * Enqueue admin assets on master trainer pages */ public function enqueue_admin_assets() { - // Debug logging - error_log('HVAC Announcements Admin: enqueue_admin_assets called'); - error_log('HVAC Announcements Admin: is_master_trainer = ' . (HVAC_Announcements_Permissions::is_master_trainer() ? 'YES' : 'NO')); - error_log('HVAC Announcements Admin: is_page_template check = ' . (is_page_template('page-master-announcements.php') ? 'YES' : 'NO')); + HVAC_Logger::log('enqueue_admin_assets called', 'Announcements Admin'); + HVAC_Logger::log('is_master_trainer = ' . (HVAC_Announcements_Permissions::is_master_trainer() ? 'YES' : 'NO'), 'Announcements Admin'); + HVAC_Logger::log('is_page_template check = ' . (is_page_template('page-master-announcements.php') ? 'YES' : 'NO'), 'Announcements Admin'); $queried = get_queried_object(); if ($queried) { - error_log('HVAC Announcements Admin: queried_object type = ' . get_class($queried)); + HVAC_Logger::log('queried_object type = ' . get_class($queried), 'Announcements Admin'); if (is_a($queried, 'WP_Post')) { - error_log('HVAC Announcements Admin: post_name = ' . $queried->post_name); - error_log('HVAC Announcements Admin: post_type = ' . $queried->post_type); + HVAC_Logger::log('post_name = ' . $queried->post_name, 'Announcements Admin'); + HVAC_Logger::log('post_type = ' . $queried->post_type, 'Announcements Admin'); $template = get_post_meta($queried->ID, '_wp_page_template', true); - error_log('HVAC Announcements Admin: page_template meta = ' . $template); + HVAC_Logger::log('page_template meta = ' . $template, 'Announcements Admin'); } } // Only enqueue on master trainer announcement pages if ($this->is_master_trainer_announcement_page()) { - error_log('HVAC Announcements Admin: ENQUEUING SCRIPTS'); + HVAC_Logger::log('ENQUEUING SCRIPTS', 'Announcements Admin'); // Enqueue editor - dependencies handled automatically wp_enqueue_editor(); diff --git a/includes/class-hvac-plugin.php b/includes/class-hvac-plugin.php index 23e99a18..815d3267 100644 --- a/includes/class-hvac-plugin.php +++ b/includes/class-hvac-plugin.php @@ -115,7 +115,7 @@ final class HVAC_Plugin { define('HVAC_PLUGIN_VERSION', '2.0.0'); } if (!defined('HVAC_VERSION')) { - define('HVAC_VERSION', '2.1.5'); + define('HVAC_VERSION', '2.1.6'); } if (!defined('HVAC_PLUGIN_FILE')) { define('HVAC_PLUGIN_FILE', dirname(__DIR__) . '/hvac-community-events.php');