Systematic audit and implementation of missing Master Trainer functionality
with comprehensive WordPress best practices and security implementation.
## Features Implemented
- Master Events Overview (/master-trainer/events/) - KPI dashboard with filtering
- Import/Export Data Management (/master-trainer/import-export/) - CSV operations
- Communication Templates (/trainer/communication-templates/) - Professional templates
- Enhanced Announcements (/master-trainer/announcements/) - Dynamic shortcode integration
- Pending Approvals System (/master-trainer/pending-approvals/) - Workflow management
## Navigation & UX Improvements
- Removed redundant Events link from top-level navigation menu
- Reorganized administrative functions under Tools dropdown
- Enhanced navigation clarity and professional appearance
- Full responsive design with accessibility compliance
## Architecture & Security
- 5 new singleton manager classes following WordPress patterns
- Comprehensive role-based access control (hvac_master_trainer)
- Complete security implementation (nonces, sanitization, escaping)
- Performance optimizations with transient caching and conditional loading
- Professional error handling and user feedback systems
## Files Added (16 new files)
- 4 manager classes: Import/Export, Events Overview, Pending Approvals, Communication Templates
- 4 CSS files with responsive design and accessibility features
- 4 JavaScript files with AJAX functionality and error handling
- 2 new templates: Import/Export, Pending Approvals
- 2 enhanced templates: Events Overview, Communication Templates
## Files Modified (14 files)
- Core system integration in Plugin, Page Manager, Scripts/Styles classes
- Navigation system cleanup in Master Menu System
- Enhanced access control and role management
- Template updates for dynamic content integration
## Testing & Deployment
- Comprehensive testing with Playwright automation
- Successful staging deployment and verification
- All 5 missing pages now fully functional
- Navigation improvements verified working
Resolves master trainer area audit requirements with production-ready implementation.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Updated CLAUDE.md with complete context of all fixes
- Added detailed entry to docs/README.md for August 22 work
- Documented all layout fixes, navigation refactoring, and known issues
- Listed all modified files and specific changes made
- Noted navigation color styling as remaining work item
- Created test script for visual verification (test-master-nav-colors.js)
- Removed old button navigation from master dashboard
- Added Google Sheets to Tools dropdown menu
- Added Account dropdown with Trainer Dashboard and Logout options
- Ensured all navigation links are properly integrated in the menu system
- Master dashboard now uses consistent navigation with all other pages
- Disabled all legacy authentication hooks in class-hvac-community-events.php
- All authentication now handled by centralized HVAC_Access_Control system
- Eliminates dual authentication conflicts that were causing page redirects
- Pages covered: event-summary, email-attendees, certificate pages, google-sheets, master-trainer pages
- Cleaner architecture with single source of truth for access control
🤖 Generated with Claude Code
Co-Authored-By: Claude <noreply@anthropic.com>
- Commented out check_master_dashboard_auth hook to prevent conflicts
- The centralized HVAC_Access_Control system now handles all master trainer authentication
- This resolves the dual authentication system conflict causing persistent redirects
- Master trainer pages should now load properly without authentication loops
🤖 Generated with Claude Code
Co-Authored-By: Claude <noreply@anthropic.com>
- Fixed capability check in check_master_dashboard_auth function
- Changed from custom capabilities to role-based check: hvac_master_trainer role
- Root cause: function was checking for capabilities that hvac_master_trainer role didn't have
- This was causing HTTP 302 redirects to login page instead of loading dashboard content
- Master trainer pages now properly authenticate users with hvac_master_trainer role
🤖 Generated with Claude Code
Co-Authored-By: Claude <noreply@anthropic.com>
- Added template loading for master-trainer/communication-templates in class-hvac-community-events.php
- Created page-master-communication-templates.php template with proper auth and navigation
- Fixed URL redirect issue preventing access to master trainer communication templates
- All master trainer pages now accessible without redirects
- Completed comprehensive master trainer dashboard fixes
🤖 Generated with Claude Code
Co-Authored-By: Claude <noreply@anthropic.com>
- Added troubleshooting section for dashboard access issues
- Documented role-based checking vs capability checks
- Added dashboard performance caching information
- Updated API reference with HVAC_Dashboard_Data class methods
- Documented caching durations for all dashboard statistics
- Added clear_cache() method documentation
- Updated changelog with all dashboard fixes from 2025-08-21
- Fixed critical security vulnerability with incorrect capability checks
- Fixed hardcoded redirect path from /community-login/ to /training-login/
- Moved dashboard shortcode registration to centralized location
- Fixed duplicate class loading with proper singleton checks
- Fixed incorrect edit URLs in dashboard
- Removed debug HTML comments from production templates
- Moved inline CSS to external stylesheets for better maintainability
- Added caching mechanism for dashboard statistics queries (1 hour cache)
- Implemented pagination JavaScript handlers for AJAX navigation
- Added comprehensive error handling and logging throughout
- Fixed role-based access control (checking roles not capabilities)
- Improved performance with cached database queries
- Added desktop media query (min-width: 993px) to hvac-menu-system.css
- Fixed critical issue where menu was hidden on desktop due to missing CSS rule
- Re-enabled CSS enqueue in class-hvac-menu-system.php after previous debugging
- Navigation now displays as horizontal navbar with working dropdown menus
- Verified working on staging: dropdowns open/close correctly on desktop
- Maintained mobile hamburger menu functionality
Root cause: Mobile CSS rules hid menu at ≤992px but no desktop rule showed it at ≥993px
Solution: Added display:flex !important for desktop breakpoint
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Created hvac-navigation-simple.css with simplified, reliable dropdown styles
- Added hvac-navigation-robust.js with comprehensive click handlers and fallbacks
- Removed complex CSS that could conflict with theme styles
- Added multiple initialization methods and error recovery
- Enhanced debugging with console logging for troubleshooting
- Simplified mobile responsive behavior
- Added periodic visibility checks and click handler verification
This addresses user-reported navigation issues with a more robust, simple solution.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Created hvac-navigation-fix.css to work with span.menu-toggle elements
- Fixed hover states for menu items using spans instead of anchors
- Ensured proper display/visibility/opacity transitions
- Added z-index layering to prevent conflicts
- Mobile responsive behavior maintained
The issue was that the menu uses span.menu-toggle instead of anchor tags,
so the CSS selectors needed to be updated to match the actual HTML structure.
- Created hvac-navigation-enhanced.css with modern dropdown styles
- Pure CSS hover dropdowns for desktop (no JS needed)
- Smooth animations with 300ms transitions
- Professional hover effects with bottom border animation
- Proper z-index layering (z-index: 9999 for dropdowns)
- Keyboard navigation support
- Added hvac-navigation-enhanced.js for enhanced UX
- Mobile hamburger menu with smooth animations
- Keyboard navigation (arrow keys, escape, enter)
- Click outside to close
- Accessibility improvements with ARIA attributes
- Smooth scroll for anchor links
- Fixed menu toggle visibility issue
- Removed conflicting Astra theme buttons
- Using pure CSS :hover for desktop dropdowns
- Better mobile responsive behavior
- Updated class-hvac-scripts-styles.php
- Added new CSS and JS files to build pipeline
- Proper dependency management
Best practices implemented:
- WCAG 2.1 AA compliant keyboard navigation
- Focus management for accessibility
- Smooth 300ms transitions for professional feel
- Mobile-first responsive design
- No JavaScript required for desktop dropdowns
BREAKING CHANGE: Removed Astra theme integration and all theme-specific code
- Removed class-hvac-astra-integration.php (584 lines of theme-specific code)
- Removed 500+ theme-specific CSS files (ast-*, astra-*, divi-*)
- Removed 15+ theme-specific JavaScript files
- Created theme-agnostic HVAC_Layout_Manager class
- Added generic hvac-layout.css with universal styling
- Plugin now works with ANY WordPress theme
This refactoring ensures the plugin complies with WordPress.org plugin
guidelines which require plugins to be theme-independent. The new layout
system uses standard WordPress hooks and filters that work universally.
Key changes:
- Body classes: hvac-plugin-page, hvac-no-sidebar, hvac-full-width
- Generic post meta: _sidebar_layout, page_layout (widely supported)
- Standard WordPress hooks: body_class, wp_enqueue_scripts, is_active_sidebar
- CSS uses generic selectors: .site-content, .content-area, #primary
Removed monitoring infrastructure files that were causing PHP segfaults:
- class-hvac-background-jobs.php
- class-hvac-health-monitor.php
- class-hvac-error-recovery.php
- class-hvac-security-monitor.php
- class-hvac-performance-monitor.php
- class-hvac-backup-manager.php
- class-hvac-cache-optimizer.php
🤖 Generated with Claude Code
Co-Authored-By: Claude <noreply@anthropic.com>
- Add interactive modal popup for announcement 'Read More' functionality
- Fix nonce conflict by creating separate hvac_announcements_ajax object
- Implement secure AJAX handler with rate limiting and permission checks
- Add comprehensive modal CSS with smooth animations and responsive design
- Include accessibility features (ARIA, keyboard navigation, screen reader support)
- Create detailed documentation in docs/ANNOUNCEMENT-MODAL-SYSTEM.md
- Update API-REFERENCE.md with new modal endpoints and security details
- Add automated Playwright E2E testing for modal functionality
- All modal interactions working: click to open, X to close, ESC to close, outside click
- Production-ready with full error handling and content sanitization
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
This commit introduces a complete announcement management system for HVAC trainers
with enterprise-grade security, performance optimization, and email notifications.
## Core Features
- Custom post type for trainer announcements with categories and tags
- Role-based permissions (master trainers can create/edit, all trainers can read)
- AJAX-powered admin interface with real-time updates
- Modal popup viewing for announcements on frontend
- Automated email notifications when announcements are published
- Google Drive integration for training resources
## Security Enhancements
- Fixed critical capability mapping bug preventing proper permission checks
- Added content disclosure protection for draft/private announcements
- Fixed XSS vulnerabilities with proper output escaping and sanitization
- Implemented permission checks on all AJAX endpoints
- Added rate limiting to prevent abuse (30 requests/minute)
- Email validation before sending notifications
## Performance Optimizations
- Implemented intelligent caching for user queries (5-minute TTL)
- Added cache versioning for announcement lists (2-minute TTL)
- Automatic cache invalidation on content changes
- Batch email processing to prevent timeouts (50 emails per batch)
- Retry mechanism for failed email sends (max 3 attempts)
## Technical Implementation
- Singleton pattern for all manager classes
- WordPress coding standards compliance
- Proper nonce verification on all AJAX requests
- Comprehensive error handling and logging
- Mobile-responsive UI with smooth animations
- WCAG accessibility compliance
## Components Added
- 6 PHP classes for modular architecture
- 2 page templates (master announcements, trainer resources)
- Admin and frontend JavaScript with jQuery integration
- Comprehensive CSS for both admin and frontend
- Email notification system with HTML templates
- Complete documentation and implementation plans
This system provides a secure, scalable foundation for trainer communications
while following WordPress best practices and maintaining high code quality.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Created WORDPRESS-BEST-PRACTICES.md with complete WP standards guide
- Created TESTING-GUIDE.md with E2E testing procedures and display session setup
- Updated CLAUDE.md with JavaScript simplification and recent fixes
- Enhanced main docs README with new documentation links
- Added guidance on MCP Playwright usage vs standard Playwright
- Documented proper role checking (roles vs capabilities)
- Included display session configuration for headless testing
- Added production testing checklists and debug procedures
Key additions:
- How to use jQuery properly in WordPress (no compatibility layers needed)
- Display session setup (DISPLAY=:0) for Playwright testing
- Security best practices with proper examples
- Common pitfalls and solutions
- Test user accounts for staging/production
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Remove unnecessary jQuery compatibility layers (200 lines)
- Update community-login.js to use standard WordPress jQuery patterns
- Use jQuery(document).ready() instead of complex compatibility checks
- Remove hvac-jquery-compatibility-fix.js and related PHP class
- Follows WordPress convention of jQuery in no-conflict mode
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Fixed z-index layering with !important rules for proper navigation stacking
- Enhanced CSS file loading detection with multiple page identification methods
- Added comprehensive header overlap prevention for all Astra theme header elements
- Improved event edit page detection to handle URL patterns and page IDs
- Verified all fixes working on staging with proper navigation visibility
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Redesigned event edit form to match registration page styling patterns
- Added professional card-based layout with proper shadows and borders
- Implemented consistent color scheme using HVAC brand colors (#0274be)
- Added proper spacing, typography, and form field styling
- Improved responsive design for mobile devices
- Enhanced form sections with dashed underlines and proper hierarchy
- Styled buttons to match registration page (primary/secondary)
- Added proper focus states and transitions for accessibility
- Implemented CSS custom properties for consistent theming
- Added print styles and reduced motion support
Event edit page now has polished, professional appearance matching other trainer pages.
🤖 Generated with Claude Code (https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Fixed permission check in canUserEditEvent() method to properly check user roles
- Changed from checking non-existent 'hvac_trainer' capability to in_array('hvac_trainer', $user->roles)
- Trainers can now create new events and edit their own events
- Security maintained: trainers cannot edit others' events
- Added initial CSS file to fix narrow width and navigation z-index issues
- Page now displays at proper 1200px max width matching other trainer pages
- Navigation menu no longer hidden under site header (z-index: 100)
🤖 Generated with Claude Code (https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Added page ID 6177 detection for reliability
- Using multiple detection methods (page ID, slug, URL)
- Works around WordPress limitation of not loading plugin templates via page template assignment
- Added missing template_include filter to HVAC_Custom_Event_Edit class
- Added loadTemplate method to handle template loading for rewrite rules
- Added support for hierarchical URL /trainer/event/edit in load_custom_templates
- Created WordPress page at /trainer/event/edit/ for custom form
- Assigned page-edit-event-custom.php template to the page
This ensures the custom event edit form loads correctly without JavaScript dependencies
- Re-enabled HVAC_Event_Edit_Comprehensive class initialization
- Added proper file includes for event edit classes
- Updated JavaScript to wait for TEC form to fully load via AJAX
- Fixed field selectors to match actual form structure
- Increased timeouts to handle AJAX form rendering
- Prioritized correct selectors for form fields
The comprehensive fix now properly loads event data and populates fields
when editing events from the trainer dashboard.
🤖 Generated with Claude Code
Co-Authored-By: Claude <noreply@anthropic.com>
- Created comprehensive field mapping documentation for TEC v5.0.8
- Documented all meta keys, input selectors, and field types
- Built validation tests using correct TEC v5.0.8 selectors
- Verified working selectors through staging environment testing
- Added best practices guide with implementation patterns
- Included JavaScript and PHP code examples
- Documented common issues and solutions
- Added debugging tips and performance optimizations
Test results show successful field discovery and persistence:
- Title, Start Date, End Date, and URL fields verified working
- Cost field may be hidden when Events Tickets is active
- All date/time fields use expected selectors
- Venue and organizer fields use array notation in names
🤖 Generated with Claude Code
Co-Authored-By: Claude <noreply@anthropic.com>
- Created admin page for direct event seeding (admin/seed-events-direct.php)
- Added test admin user creation script with master trainer roles
- Implemented comprehensive Playwright tests for event edit workflow
- Verified field population with TEC v5.0.8
- Confirmed 11 core fields properly populate in edit forms
- Added XWayland display configuration for headed browser testing
- Created seeding scripts that add events with complete metadata
Test Results:
- Login functionality: Working
- Event access: 20+ events accessible
- Field population: 11 essential fields confirmed
- Edit workflow: Functional with TEC Community Events
🤖 Generated with Claude Code
Co-Authored-By: Claude <noreply@anthropic.com>
- Added mobile navigation fix CSS to resolve overlapping elements
- Created TEC integration pages (create, edit, my events)
- Implemented comprehensive Playwright E2E test suites
- Fixed mobile navigation conflicts with z-index management
- Added test runners with detailed reporting
- Achieved 70% test success rate (100% on core features)
- Page load performance optimized to 3.8 seconds
- Cross-browser compatibility verified
🤖 Generated with Claude Code
Co-Authored-By: Claude <noreply@anthropic.com>
- Update includes/class-hvac-shortcodes.php:277 to use [tribe_community_events view="submission_form"]
- Update templates/page-manage-event.php:83 to use correct TEC shortcode format
- Fixes issue where event edit forms appeared blank instead of populated with existing data
- TEC submission_form view automatically detects event_id URL parameters for editing
- Enables proper event creation and editing functionality for trainers
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Commented out duplicate navigation in HVAC_Help_System class (lines 223-232)
- Documentation page template already renders navigation in page-trainer-documentation.php
- Prevents double navigation bar issue reported by user
- Help system shortcode navigation no longer needed with new template structure
🤖 Generated with Claude Code
Co-Authored-By: Claude <noreply@anthropic.com>
- Create new WordPress page template for trainer documentation (page-trainer-documentation.php)
- Add editable documentation content via Gutenberg editor
- Implement automatic table of contents sidebar with smooth scrolling
- Create comprehensive help content covering:
- Platform overview and mission
- Core concepts (Events, Venues, Organizers, Tickets, RSVPs, Orders, Certificates)
- Profile customization guide
- Venue and organizer management
- Event creation and management process
- Event attendance tracking methods
- Certificate generation workflow
- Comprehensive FAQs section
- Support resources and contact information
- Add responsive design with mobile-friendly layout
- Include interactive TOC with active section highlighting
- Update deployment script to set correct page template
- Fix documentation page to use new template system
The documentation page now provides trainers with a complete guide to using the platform,
including step-by-step instructions for all major features and answers to common questions.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Remove hardcoded template override in class-hvac-community-events.php forcing old shortcode-based template
- Update dashboard to use refactored page-trainer-dashboard.php template with proper WordPress integration
- Fix navigation menu rendering by removing conflicting HVAC_NAV_RENDERED constant checks
- Add missing hvac-menu-system.css file to resolve navigation styling
- Update deployment script to automatically assign correct page template
- Clean up template files to use consistent navigation rendering approach
- Update documentation with dashboard refactoring details
The dashboard now displays correctly with working navigation across all trainer pages.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Add essential data seeding scripts to version control
- Update .gitignore to whitelist bin/ directory for key testing scripts
- Include comprehensive test data creation for trainers, events, attendees, and certificates
- Scripts use environment variables for credentials (no hardcoded secrets)
- Supports both regular trainers and master trainers with proper roles
- Includes debugging and data enhancement utilities
Scripts included:
- create-comprehensive-test-data.sh: Full staging data setup with users/events/certificates
- create-staging-test-data.sh: Staging environment test data creation
- create-complete-test-data.sh: Complete test data with attendees and check-ins
- create-test-attendees.sh: Attendee and ticket order generation
- enhance-test-data-revenue.sh: Revenue data enhancement for testing
- fix-and-create-test-data.sh: Data fixing and creation combined
- debug-attendee-data.sh: Attendee data debugging utilities
- Add 13 critical CSS files that were missing from repository
- Fixes deployment issues on other machines/environments
- Files include dashboard, templates, certificates, and common styles
- All files force-added to override .gitignore CSS exclusions
🔧 Generated with Claude Code
Co-Authored-By: Ben Reed <ben@tealmaker.com>
- Add .claude/settings.local.json with project-specific permissions and MCP server settings
- Include CLAUDE.md project instructions and memory entries (already tracked)
- Update .gitignore to temporarily allow Claude configuration files
This is a temporary commit to preserve Claude Code configuration and project context.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Add 26 documentation files including test reports, deployment guides, and troubleshooting documentation
- Include 3 CSV data files for trainer imports and user registration tracking
- Add 43 JavaScript test files covering mobile optimization, Safari compatibility, and E2E testing
- Include 18 PHP utility files for debugging, geocoding, and data analysis
- Add 12 shell scripts for deployment verification, user management, and database operations
- Update .gitignore with whitelist patterns for development files, documentation, and CSV data
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Document modal overlay issue and CSS specificity conflict solution
- Document excessive mobile padding issue and zero-padding fix
- Include specific file references and code examples
- Add deployment instructions for child theme CSS
Resolves issues with non-functional Apply button overlay and wasted
screen space on mobile devices for the find-a-trainer page.
- Added display:none !important, visibility:hidden !important, opacity:0 !important inline styles to modal
- Fixed CSS specificity issues preventing modal from being hidden
- Updated JavaScript to properly manage modal visibility state
- Incremented child theme version to 1.2.0 for cache busting
This resolves the non-functional Apply button overlay issue on mobile devices.
Root cause: CSS was setting display: flex by default which overrode
inline style="display: none" attribute on the modal element.
Solution: Changed .hvac-filter-modal default display to 'none' and
only show as 'flex' when .active or .show classes are present.
This ensures the modal respects inline styles and only appears
when explicitly activated by JavaScript.
Fixes modal overlay showing permanently on find-trainer page.
