From 98cbe83813510f771f8345a0f03d16357e44415a Mon Sep 17 00:00:00 2001 From: Ben Date: Mon, 11 Aug 2025 17:27:08 -0300 Subject: [PATCH] fix: Remove duplicate navigation on documentation page MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Commented out duplicate navigation in HVAC_Help_System class (lines 223-232) - Documentation page template already renders navigation in page-trainer-documentation.php - Prevents double navigation bar issue reported by user - Help system shortcode navigation no longer needed with new template structure 🤖 Generated with Claude Code Co-Authored-By: Claude --- CLAUDE.md | 1 + includes/class-hvac-help-system.php | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CLAUDE.md b/CLAUDE.md index 1b128db2..94f2017f 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -253,5 +253,6 @@ The following systems are commented out in `/includes/class-hvac-plugin.php` lin - **Safari Browser Compatibility Resolution (2025-08-08)**: ✅ **RESOLVED** - Critical Safari browser hanging issues completely resolved through comprehensive resource loading optimization system. Root cause identified as 35+ separate CSS file enqueue calls creating a resource loading cascade that overwhelmed Safari's rendering engine. Investigation revealed JavaScript syntax error in MapGeo integration and excessive component initialization cascade. Solution: Deployed Safari-specific resource loading bypass that detects Safari browsers and loads only 1 consolidated CSS file instead of 35+, automatically dequeues non-critical assets, implements intelligent browser detection with HVAC_Browser_Detection class, and maintains full functionality while preventing browser hangs. Additional fixes: removed CSS @import statements causing render blocking, optimized database queries in find-trainer template, implemented lazy component loading, reduced Astra theme hook priorities from 999 to 50, fixed JavaScript syntax error (dangling }) in MapGeo integration. Testing verified with Playwright WebKit engine - page loads successfully with complete functionality including interactive map, trainer cards, and navigation. Resource optimization reduced CSS files from 35+ to 3 core files. Production verification confirmed: **"THE PAGE FINALLY LOADS IN SAFARI!!!!!!!"** - User confirmation of successful resolution. Complete technical documentation in docs/SAFARI-COMPATIBILITY-INVESTIGATION.md. Status: Production-ready and user-verified working. - **Registration Form Production Deployment and Verification (2025-08-08)**: Successfully deployed updated registration form to production environment using `scripts/deploy.sh production`. Comprehensive Playwright E2E tests executed against production site (https://upskillhvac.com/trainer/registration/) with 100% pass rate. Test verification confirmed: all 40+ form fields functional with proper Business Type dropdown (11 options), Training Audience multi-select checkboxes (4 options), dynamic Organization Headquarters country/state dropdowns with automatic US/Canada state loading, file upload functionality for profile images and organization logos, complete form submission workflow, user registration with redirect to /registration-pending/. Database verification completed on production server: user account created (ID: 65), all user meta fields stored correctly (business_name, business_email, training_audience serialized array, first_name, last_name, application_details, business_type), organizer post created (ID: 6020 - "Test HVAC Training Company 1754663473108"), venue post created (ID: 6022 - "Test Training Center Dallas 1754663473108"). Registration system fully operational in production with complete end-to-end functionality verified through automated testing and manual database inspection. Test email: test.registration.1754663473108@example.com used for verification. - **Trainer Dashboard Template Refactoring (2025-08-11)**: Fixed critical dashboard and navigation issues. Root cause: hardcoded template override in `class-hvac-community-events.php` lines 804-806 forcing old shortcode-based template. Solution: removed hardcoded override, updated to use refactored `page-trainer-dashboard.php` template with proper WordPress integration. Fixed navigation menu rendering by removing conflicting `HVAC_NAV_RENDERED` constant checks in `class-hvac-menu-system.php` and page templates. Added missing `hvac-menu-system.css` file via git pull. Dashboard now displays correctly with working navigation across all trainer pages. Deployment script updated to automatically assign correct page template during deployment. +- **Documentation Page Double Navigation Fix (2025-08-11)**: Resolved duplicate navigation bar issue on documentation page. Root cause: HVAC_Help_System class was rendering its own navigation (lines 223-231) via `[hvac_documentation]` shortcode while page template also rendered navigation. Solution: commented out duplicate navigation in `class-hvac-help-system.php`. Documentation page now uses comprehensive template (`page-trainer-documentation.php`) with table of contents sidebar, WordPress/Gutenberg integration, and single navigation instance. Help content provided via `HVAC_Documentation_Content` class with fallback to shortcode for empty pages. [... rest of the existing content remains unchanged ...] \ No newline at end of file diff --git a/includes/class-hvac-help-system.php b/includes/class-hvac-help-system.php index 2a174851..9a3223c8 100644 --- a/includes/class-hvac-help-system.php +++ b/includes/class-hvac-help-system.php @@ -220,7 +220,8 @@ class HVAC_Help_System {

Everything you need to know about managing your training events

-
+ +
get_documentation_content(); ?>