UX follow-ups deferred from the #9 review #12

Closed
opened 2026-10-15 15:52:21 +00:00 by ben · 1 comment
Owner

These Low items were deferred from the #9 review (see the completion notes in docs/plans/2026-10-15-07-37_ux-nav-layout-help.md) and from earlier reviews (STATUS.md):

  • The skip link does nothing while the builder preview is open.
  • Resend or Revoke on a client reached with "Load more" reloads the dashboard list from page 1. Refresh only that card, or reload up to the page already loaded.
  • Add e2e journeys for revoking an invitation, Create user, Counsellor links and outbox retry.
  • A note that fails to save in a session you've already closed shows no warning until the session is reopened.
  • The builder list has no retry button after a failed refresh.
  • The first keystroke after a failed note save re-renders once, which can interrupt IME composition.
  • The "hidden" event (a tab switch) during a pending account check sends left notes without waiting for the check. Writes stay protected by the account header.
These Low items were deferred from the #9 review (see the completion notes in `docs/plans/2026-10-15-07-37_ux-nav-layout-help.md`) and from earlier reviews (`STATUS.md`): - The skip link does nothing while the builder preview is open. - Resend or Revoke on a client reached with "Load more" reloads the dashboard list from page 1. Refresh only that card, or reload up to the page already loaded. - Add e2e journeys for revoking an invitation, Create user, Counsellor links and outbox retry. - A note that fails to save in a session you've already closed shows no warning until the session is reopened. - The builder list has no retry button after a failed refresh. - The first keystroke after a failed note save re-renders once, which can interrupt IME composition. - The "hidden" event (a tab switch) during a pending account check sends left notes without waiting for the check. Writes stay protected by the account header.
ben closed this issue 2026-10-16 15:36:52 +00:00
Author
Owner

Landed in 48af0c2 (plan docs/plans/2026-10-16-06-30_ux-followups-from-nine-review.md, now done):

  • Skip link: focuses the visible main, including the builder preview board and summary (web/src/nav.ts visibleMain(), help.ts, activity-preview.ts).
  • Builder list: a "Retry loading activities" button after a retryable list failure (web/src/builder.ts).
  • Dashboard: Resend/Revoke reload through the loaded pages and always bring back the acted-on client; after Revoke, focus moves to that client's Resend (dashboard.ts reloadLoaded, page-actions.ts focus/focusAfter).
  • IME: the first keystroke after a stopped save clears only the warning container and the status; the textarea is not replaced (main.ts).
  • Left-session failures: a notice bar (#app-notice, web/src/left-notes.ts) links to each other session holding a stopped, conflicted or removed draft. It is hidden during sign-in confirmation and the password offer.
  • "hidden" during a pending account check: kept by design (maintainer decision). The client already holds back while writes are suspended or a sign-in is confirming, the account header rejects cross-account writes, and on mobile "hidden" is often the last event. Pinned by web/test/nav.test.ts.
  • E2E: revoke invite, Create user, counsellor Link/Unlink and outbox Retry (web/e2e/dashboard.spec.ts, people.spec.ts, outbox.spec.ts).

Verified: tsc clean; web unit 685 passed with coverage ≥85% per file; Playwright 13 passed, 1 skipped; server 1351 passed. Reviewed by one Claude worker (Medium): no Critical/High; 2 Medium and 3 Low fixed, delta re-review clean.

Left (minor, in STATUS.md): after a page reload, leftover left-session drafts are sent only when that session is reopened (predates this); a failed reload after a Revoke leaves the card stale until Refresh. Not yet deployed (no migration).

Landed in 48af0c2 (plan `docs/plans/2026-10-16-06-30_ux-followups-from-nine-review.md`, now done): - **Skip link:** focuses the visible `main`, including the builder preview board and summary (`web/src/nav.ts` `visibleMain()`, `help.ts`, `activity-preview.ts`). - **Builder list:** a "Retry loading activities" button after a retryable list failure (`web/src/builder.ts`). - **Dashboard:** Resend/Revoke reload through the loaded pages and always bring back the acted-on client; after Revoke, focus moves to that client's Resend (`dashboard.ts` `reloadLoaded`, `page-actions.ts` `focus`/`focusAfter`). - **IME:** the first keystroke after a stopped save clears only the warning container and the status; the textarea is not replaced (`main.ts`). - **Left-session failures:** a notice bar (`#app-notice`, `web/src/left-notes.ts`) links to each other session holding a stopped, conflicted or removed draft. It is hidden during sign-in confirmation and the password offer. - **"hidden" during a pending account check:** kept by design (maintainer decision). The client already holds back while writes are suspended or a sign-in is confirming, the account header rejects cross-account writes, and on mobile "hidden" is often the last event. Pinned by `web/test/nav.test.ts`. - **E2E:** revoke invite, Create user, counsellor Link/Unlink and outbox Retry (`web/e2e/dashboard.spec.ts`, `people.spec.ts`, `outbox.spec.ts`). **Verified:** `tsc` clean; web unit 685 passed with coverage ≥85% per file; Playwright 13 passed, 1 skipped; server 1351 passed. Reviewed by one Claude worker (Medium): no Critical/High; 2 Medium and 3 Low fixed, delta re-review clean. **Left (minor, in STATUS.md):** after a page reload, leftover left-session drafts are sent only when that session is reopened (predates this); a failed reload after a Revoke leaves the card stale until Refresh. Not yet deployed (no migration).
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ben/career-values-cards#12
No description provided.